Skip to content

Conversation

@flowftw
Copy link
Collaborator

@flowftw flowftw commented Nov 21, 2025

Subject

  • Please write the development content.

Changes Description

  • Please write the main changes or the contents to be referred to in the review.

How to test

  • Please describe the prerequisites and the steps to test

Evident for results

  • Please attach images or videos to confirm the right result

Referenced Ticket

@flowftw flowftw requested a review from rcmorano as a code owner November 21, 2025 11:43
@flowftw flowftw marked this pull request as draft November 21, 2025 11:43
@flowftw flowftw force-pushed the chore/e2e-api-tests branch from 3b36017 to 2643ba1 Compare November 21, 2025 11:48
@flowftw flowftw removed the request for review from rcmorano November 27, 2025 11:14
@flowftw flowftw marked this pull request as ready for review December 2, 2025 09:23
Kammerlo
Kammerlo previously approved these changes Dec 7, 2025
Copy link
Member

@Kammerlo Kammerlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but I would love to see it in action before merging and what are the impacts from a development perspective, if there are any?
And probably it's helpful if we have the option run this locally as well, would make dev faster.

…(automated commit by gha run id 20020394858)
@flowftw
Copy link
Collaborator Author

flowftw commented Dec 8, 2025

The code looks good, but I would love to see it in action before merging and what are the impacts from a development perspective, if there are any? And probably it's helpful if we have the option run this locally as well, would make dev faster.

@Kammerlo your workflow should not change drastically using this action. At least that was the intention. The action simply makes it easier to get application builds based on your feature branch in cf-reeve-platform which you are working on. So the intended workflow would be that you create a PR in cf-reeve-platform and start working on your features there. This should be true for most of our features. As soon as you start pushing changes to that feature branch the resulting platform version gets synced to the same branch in cf-reeve-application. If there was no branch with the exact same name found, a new branch and a PR will be opened.
This also ensures that all API and E2E tests are executed in a timely manner since change in cf-reeve-platform always trigger commits in cf-reeve-application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants